Fix/nfnd gitmessage #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Juan Pablo Garcia Ripa <juanp.garcia@bbva.com> Co-authored-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Co-authored-by: Juan Pablo Garcia Ripa <juanp.garcia@bbva.com> Co-authored-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Co-authored-by: Juan Pablo Garcia Ripa <juanp.garcia@bbva.com> Co-authored-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
Co-authored-by: Juan Pablo Garcia Ripa <juanp.garcia@bbva.com> Co-authored-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
|
fixed the branch mess sorry for that... |
This was referenced Jun 5, 2018
|
Hey @Sarabadu, thanks for the patch! I tested with git 2.7.4 and it works. I'll go ahead and merge this. I'm wondering if, as a future improvement, we can avoid having to shell out (i.e. running another git process in a new shell to get the git version). If we switch to an absolute path for the commit template, we could have a solution that works in older git versions as well. E.g. Something for us to think about. Until then, this patch will work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed .gitmessage not found from sub directories