- Unused method/property in YieldPolyfillIterator::__construct

Author: rkrx

src/Builder/Helpers/YieldPolyfillIterator.php

@@ -8,8 +8,6 @@
 use PDO;
 
 class YieldPolyfillIterator implements Iterator {
-	/** @var RunnableSelect */
-	private $select;
 	/** @var Closure|null */
 	private $callback;
 	/** @var bool */
@@ -24,13 +22,11 @@ class YieldPolyfillIterator implements Iterator {
 	private $idx = -1;
 
 	/**
-	 * @param RunnableSelect $select
 	 * @param Closure|null $callback
 	 * @param bool $preserveTypes
 	 * @param callable $statementFactory
 	 */
-	public function __construct(RunnableSelect $select, Closure $callback = null, $preserveTypes, $statementFactory) {
-		$this->select = $select;
+	public function __construct(Closure $callback = null, $preserveTypes, $statementFactory) {
 		$this->callback = $callback;
 		$this->preserveTypes = $preserveTypes;
 		$this->statementFactory = $statementFactory;
@@ -61,9 +57,8 @@ public function current() {
 			} else {
 				return $row;
 			}
-		} else {
-			return $row;
 		}
+		return $row;
 	}
 
 	/**

src/Builder/RunnableSelect.php

@@ -92,7 +92,7 @@ public function fetchRows(Closure $callback = null) {
 	 */
 	public function fetchRowsLazy(Closure $callback = null) {
 		if(version_compare(PHP_VERSION, '5.5', '<')) {
-			return new YieldPolyfillIterator($this, $callback, $this->preserveTypes, function () {
+			return new YieldPolyfillIterator($callback, $this->preserveTypes, function () {
 				return $this->createStatement();
 			});
 		}