-
Notifications
You must be signed in to change notification settings - Fork 884
spec: get rid of fulfills for the volumes #182
Comments
@philips this isn't strictly solving your issue because it's still possible to have collisions:
i.e. we then need to validate name uniqueness. Maybe we want to make this change anyway (?) but it seems we could just as easily fix the issue by asserting that |
We need to validate name uniqueness in the volumes and the app. The problem I am trying to solve is that two apps might have two mount points with identical names but different meanings. |
@jonboulle does this make sense? I want to move forward with the work on this. |
@jonboulle Does this example help:
|
Yeah that clarifies (although holy complicated command line, batman) |
It also brings up the point again that we need to decide about label uniqueness (eg what if someone runs two example.com/webapp with different versions in a single container?) |
@jonboulle Yea the command line is ugly. On your second point we shouldn't attempt to make everything a CLI flag. We can support the 80% use cases. But, if as you point out, people want multiple copies of the same app they will need to write a JSON object instead. |
This issue was moved to appc/spec#13 |
I am struggling to get the volumes seen inside rocket container .... the manifest file looks like: My application does see the volumes inside the container .. I cannot see systemd-nspawn not having any bind mount in its command line stage1/usr/lib/ld-linux-x86-64.so.2 stage1/usr/bin/systemd-nspawn --boot --register false --uuid=4499f289-952f-4f86-9bf9-08b6cd21d769 --directory=stage1 -- --default-standard-output=tty] what's wrong here? |
What is your rkt command line? On Wed, Dec 10, 2014 at 4:22 PM, Vaibhav Khanduja notifications@github.com
|
My rocket command line did not include any special volume parameter ...
Closed #182.— |
Volumes are not part of the image manifest spec, only mountPoints are: https://github.com/appc/spec/blob/master/SPEC.md#manifest-schemas Keep the mountPoint in your image manifest, and then try The way this is structured will likely change as we resolve appc/spec#13 |
I guess then it is a bug on actool as it validated the manifest file with volume ..
Volumes are not part of the image manifest spec, only mountPoints are: https://github.com/appc/spec/blob/master/SPEC.md#manifest-schemasKeep the mountPoint in your image manifest, and then try rkt run -volume work:/data, that should do it.The way this is structured will likely change as we resolve appc/spec#13— |
We do not validate any superfluous fields in the manifests as we have not really strictly mandated this. We could consider being stricter /cc @philips |
Right now volumes in the container can fulfill particular labels. This is a bit troublesome because there might be colliding names for the same volume.
https://github.com/coreos/rocket/blob/master/app-container/SPEC.md#container-runtime-manifest-schema
Instead of doing this give each volume a name and each app will get volumes filled in by name to its mountpoints.
The text was updated successfully, but these errors were encountered: