Fix template command to not print list of deleted files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For all wrapped Helm commands the list of decrypted files is printed as they get removed at the end of plugin execution. For the `template` command this is undesired, as it means you cannot simply run `helm secrets template` and get valid YAML output. This change suppresses the output of deleted files for the `template` only, meaning it does not alter the behavior of other commands, but just fixes the `template` command to work as I imagine most people would expect it to work. [Fixes issues zendesk#126 and zendesk#132]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all wrapped Helm commands the list of decrypted files are printed as
they get removed at the end of plugin execution. For the
templatecommand this is undesired, as it means you cannot simply run
helm secrets templateand get valid YAML output.This change suppresses the output of deleted files for the
templatecommand only, meaning it does not alter the behavior of other commands, but just
fixes the
templatecommand to work as I imagine most people wouldexpect it to work.
[Fixes issues zendesk#126 and zendesk#132]