Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌟feature(windows terminal): supported #5

Merged
merged 4 commits into from
Jan 1, 2022
Merged

🌟feature(windows terminal): supported #5

merged 4 commits into from
Jan 1, 2022

Conversation

brokenricefilms
Copy link
Contributor

This was referenced Dec 31, 2021
Merged
Closed
@rktjmp
Copy link
Owner

rktjmp commented Dec 31, 2021

👍 Should name included in check_keys?

https://docs.microsoft.com/en-us/windows/terminal/customize-settings/color-schemes#creating-your-own-color-scheme Doesn't really say what's required, but maybe? Most (all?) on https://windowsterminalthemes.dev/ have the name key.

@brokenricefilms
Copy link
Contributor Author

+1 Should name included in check_keys?

https://docs.microsoft.com/en-us/windows/terminal/customize-settings/color-schemes#creating-your-own-color-scheme Doesn't really say what's required, but maybe? Most (all?) on https://windowsterminalthemes.dev/ have the name key.

  • yep 👍 , i just add the name in check_keys, will it work?

rktjmp
rktjmp reviewed Dec 31, 2021
View reviewed changes
Copy link
Owner

@rktjmp rktjmp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to correct the @param documentation, it should be a valid lua table, see comments. Sorry, didn't notice it before.

lua/shipwright/transform/contrib/windows_terminal.lua Outdated Show resolved Hide resolved
lua/shipwright/transform/contrib/windows_terminal.lua Outdated Show resolved Hide resolved
lua/shipwright/transform/contrib/windows_terminal.lua Outdated Show resolved Hide resolved
@rktjmp rktjmp merged commit c58958f into rktjmp:master Jan 1, 2022
@rktjmp
Copy link
Owner

rktjmp commented Jan 1, 2022

⚓ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rktjmp rktjmp rktjmp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brokenricefilms @rktjmp