Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qnh override #92

Merged
merged 29 commits into from
May 5, 2021
Merged

Qnh override #92

merged 29 commits into from
May 5, 2021

Conversation

talbotmcinnis
Copy link
Contributor

This started with the goal of being able to work around the temperature/pressure issue we discovered a while back. Our squad is very sensitive to the expected QNH setting causing an exact match to aircraft values at the EOR areas,

QNH 30.02 is a supported option.

However this exposed challenges applying that override to QFE. Thus I included something I've been meaning to do anyway, add "NO QFE" and "NO HPA" options to suppress those from the remarks sections.

As always, welcoming all feedback. Cheers.

@rkusa
Copy link
Owner

rkusa commented Apr 25, 2021

Thanks for the PR! Would you mind giving #93 to see if we maybe don't even need the override?

@talbotmcinnis
Copy link
Contributor Author

talbotmcinnis commented Apr 25, 2021 via email

@rkusa
Copy link
Owner

rkusa commented May 2, 2021

v3.0.1 hopefully fixes the QNH deviations so that we don't need the QNH override. Adding NO QFE and NO hPa (we might wanna make hPa case-insensitive so that it works for both NO HPA and NO hPA, wdyt?) is still fine for me.

@talbotmcinnis
Copy link
Contributor Author

Good idea regarding case sensitivity. I will remove the qnh override now. I also am not attached to the exact phrasing so feel free to make a change if you wish. I'll try to push my changes tonight or Monday.

@talbotmcinnis
Copy link
Contributor Author

Ok, QNH OVERRIDE option has been removed, NO X options are now case insensitive, and the branch has been deconflicted.

Let me know if you see anything else, otherwise as far as I'm concerned this is ready to merge :)

Copy link
Owner

@rkusa rkusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍👏

@rkusa rkusa merged commit 8b95ad5 into rkusa:master May 5, 2021
rkusa added a commit that referenced this pull request May 5, 2021
@rkusa
Copy link
Owner

rkusa commented May 5, 2021

⛵ released as part of https://github.com/rkusa/DATIS/releases/tag/3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants