Flipkin: Add binary command detection for reduce, probe, and prekin. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredsampson
changed the title
Check for standalone and PHENIX-associated executables (e.g. 'reduce' and 'phenix.reduce') in that order, and uses the first one found to execute the program calls. If neither option is found, dies with an error.
jaredsampson
force-pushed
the
flipkin-binary-detection
branch
from
0a68e65
to
44006a4
Compare
|
Hi MolProbity devs - Have you considered incorporating this change (or one like it) to allow flipkin to use standalone (i.e. non-Phenix) versions of reduce, probe, and prekin? In writing the PyMOLProbity plugin (MolProbity-style visualization for PyMOL), I wanted to allow people to use the plugin without installing all of Phenix, so I patched Flipkin and linked to my fork in the installation instructions. It'd be nice to be able to point them to the official distribution instead. Let me know if you have any concerns or suggestions...Perl isn't my native language... @rlabduke @bhintze @chrissciwilliams |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users without a PHENIX installation, hard-coding
phenix.xxxpaths in theflipkinscript (added in 7c39436) is problematic and requires either tinkering with the source or installing an outdated version.To remedy this, I patched Flipkin to check the shell
PATHfor standalone and PHENIX-associated executables (e.g.reduceandphenix.reduce) in that order, and use the first one found to execute the program calls. If neither option is found, it now dies with an error asking to please install the program in question.