Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com:jojessf/perl-Amazon-S3 Init #9

Closed
wants to merge 1 commit into from

Conversation

jojessf
Copy link

@jojessf jojessf commented Jan 24, 2023

add $Bucket->copy_key( $inkey, $newkey ) <3

add Bucket->copy_key(inkey,newkey)
@rlauer6
Copy link
Owner

rlauer6 commented Jan 24, 2023

Hi! Thanks for the PR!....I'll incorporate this into the next version, however I will be making a few changes to satisfy perlcritic ... also README.md is autogenerated from the pod. Thanks again!

@rlauer6
Copy link
Owner

rlauer6 commented Jan 25, 2023

Spent some time today looking at the CopyObject request API. I think we can beef up copy_key a bit so that it allows for more flexible exercising of that API.

New branch copy_object pushed this morning...check out the documentation in Amazon::S3::Bucket for copy_object and see what you think. I've also added a very basic unit test for copy_object() in t/01-api.t.

@rlauer6
Copy link
Owner

rlauer6 commented Feb 4, 2023

As I have not gotten any feedback, I am incorporating the new copy_object() method into the new 0.59 version and closing this PR.

@rlauer6 rlauer6 closed this Feb 4, 2023
@jojessf
Copy link
Author

jojessf commented Feb 5, 2023

Have been unfortunately busy. I like your implementation of copy_object, and it does what it needs to do. Copies an object, optionally between buckets.

Did spend a bit of time considering it, but I do not have anything tangible to offer at this time. Would like convenience methods for "x-amz-copy-source-if-modified-since" & "x-amz-copy-source-if-match" - but I haven't had the time to figure out how to get those to actually work just yet. Also want convenience methods to add tags, inhibit tag inheritance, inhibit the inheritance of specific tags - but haven't tested any of that.

Might come back with another PR when I have more time to put into this - if that's okay with you, of course.

Thank you, rlauer6! =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants