-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jax DQN & Improvements to AgentStats #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the agent twice when n_fit=1.
…). Avoids issues with jax agents, for instance.
…ptimize ( gc_after_trial=True) to avoid running out of memory.
…eeds from optuna (hyperparam optim in parallel is already non-deterministic and different processes were sharing the same seed)
…mory consumption to increase a lot as the agent was used in optimize_hyperparams(). Added comment in the file explaining the bug.
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 87.05% 86.89% -0.16%
==========================================
Files 142 149 +7
Lines 7186 7457 +271
==========================================
+ Hits 6256 6480 +224
- Misses 930 977 +47
Continue to review full report at Codecov.
|
…ent, it always uses self.output_dir. optimize_hyperparams() saves the object before starting the optimization, so that the optuna study can be restored later, even if the program is interrupted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AgentStats
class, so that it works well with JAX agents:spawn
instead offork
in multiprocessing (see jax does not work with the multiprocessing "fork" strategy. jax-ml/jax#1805);eval_env
is now created in theAgent
class (and can be optionally sent to the constructor). This makes it easier to define theAgent.eval() method.