Removed CDN dependencies #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but is there any reason to include mapping file here? |
|
Very good point and now that I think about it I understand. When I tested earlier, I used the debugger to check if the UI was downloading everything from the static folder. As it turns out, debugger opened + minified library; the debugger tried to download the .map file, and instinctively, I have added it since it was making a 404 error. It's safe to remove the file if you wish. |
|
Merged without .map file and a reference to it in jquery (last line, maybe debugger was making requests because of it). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In corporate environments, there might be a lack of Internet access, so no CDN either. This pull request simply add jQuery 1.11.0 to the
lib/staticfolder and use it for the Web UI.