Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current search code is based on the PR #65, which was using a primitive approach:
/-/all
from npmjsJSON.parse()
on it, trying to parse it's entire output into memoryNow that
npm
database it larger, the 3rd step is usually getting replaced with "eat up 2+GB of memory and crash" step.So I changed it to use streaming, and now it works like this:
/-/all
from npmjsJSONStream
and parse each package in the outputThis should fix most of our search-related issues. By the way, on my computer
npm
is still crashing trying to parse the entireall.json
, so whoever has a time and patience for it, please check if this commit works. :)