Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

recursive domain lookup for #31 #38

Merged
merged 2 commits into from
Jul 21, 2015
Merged

recursive domain lookup for #31 #38

merged 2 commits into from
Jul 21, 2015

Conversation

eridal
Copy link
Contributor

@eridal eridal commented Jul 16, 2015

I have added the snippet to load recursively the domains, so for "www.example.com" it will attempt to load:

  1. www.example.com.js
  2. example.com.js
  3. com.js

please let me know how that goes!

@eridal eridal mentioned this pull request Jul 17, 2015
@rlr
Copy link
Owner

rlr commented Jul 20, 2015

awesome! Thanks! I'll take a look at this soon. Sorry for the delay

@rlr
Copy link
Owner

rlr commented Jul 21, 2015

looks good to me! I'll need to figure out how to build this thing again. It's been a while. Thanks!

rlr added a commit that referenced this pull request Jul 21, 2015
@rlr rlr merged commit 0e6e9c4 into rlr:master Jul 21, 2015
@eridal
Copy link
Contributor Author

eridal commented Jul 21, 2015

Nice!

Thanks for taking the time.

@rlr
Copy link
Owner

rlr commented Aug 27, 2015

I finally got around to building the xpi and submitting it for review. Thanks again!

@eridal
Copy link
Contributor Author

eridal commented Aug 28, 2015

You rock!

Can you document the steps required, for future reference?
El ago. 27, 2015 4:10 PM, "ricky rosario" notifications@github.com
escribió:

I finally got around to building the xpi and submitting it for review.
Thanks again!


Reply to this email directly or view it on GitHub
#38 (comment).

@eridal
Copy link
Contributor Author

eridal commented Jan 13, 2016

Hey Ricky,

Any idea when this was published?
I have 0.13.0 installed but seems that it's not there

@rlr
Copy link
Owner

rlr commented Jan 13, 2016

this landed and worked but may have broke since then since I refactored some of that code :/

@eridal
Copy link
Contributor Author

eridal commented Jan 13, 2016

Well, apparently removing and adding it back resolved the issue.

Sorry for the noise :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants