-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OctoberCMS with Laravel 5 and Laravel 6 compatibility #5
Comments
I reported it to the OctoberCMS team, it seems to be an issue related to Marketplace itself. I'll keep following its progress. |
Install the plugin from Github:
It should install all the plugins dependency and you are good to go. |
The plugin was updated successfully by October but nothing changed. The "composer/installers" plugin was skipped because it requires a Plugin API version ("^1.0") that does not match your Composer installation ("2.0.0"). You may need to run composer update with the "--no-plugins" option.
I get now a white screen, in backend and frontend ;-(( |
Wow! @Incremental92 this is really helpful. Thank you. Let me see if I can reproduce it, and figured out what is going on. |
You're welcome. |
@Incremental92 I updated the instructions, I tested it here, and seems to work fine. Can you test it? No updates from Market Place yet. |
OK. I definitely know what is the issue. But, I have no idea how to fix it. It seems that the OctoberCMS rollback its version to not support Laravel 6, unless if you install and update the OctoberCMS using composer. So, it is causing all the issues, 'cause the plugin libraries don't support Laravel 5 anymore. I mean, it should, but, apparently 'cause of the way that Laravel manages its dependency when you install the plugin direct from the Marketplace... it tries to download the wrong dependency versions. I can only advise you, for now, to recreate your project with composer and then, after update the OctoberCMS with the I don't see the advantage and migrate the plugin back to Laravel 5.5, once the support to Laravel 6 should be released in the next months. |
Thanks for your feedback. |
You can download an older version of the plugin from GitHub, just check the releases. I guess that the v1.0.3 should work with L5.5. Sorry about it, but it all seems to happened 'cause OctoberCMS had a premature release of L6, then they decided to rollback to L5.5 - and now we have two possible Laravel versions out there. About the Builder, if I'm not mistaken you could just create a new OctoberCMS project with Composer and update it via composer as well, then... you probably would be fine if you move your plugin folder, created by the Builder to the new project, also, installing the Builder there, and it can "find" your plugin. Of course, that it will require some extra work and exploration, but it should be totally possible. I can't guide you on that, 'cause, as I said, it will require some exploration and understand of the possible error messages or issues that you may be ending up founding. But it should be possible, and should not be hard, just boring. So, for now, I'll mark this issue as wontfix since I'm not planning to roll back the plugin release as the L6 update coming in the next close months. Hope you understand. |
BTW... How to check if your OctoberCMS is using the L5.5 or L6 version? Easy. Done! Now you know which Laravel version your OctoberCMS is using. Keep in mind that it is possible to convert a non-composer OctoberCMS installation to a composer installation. So, you may not need to reinstall your OctoberCMS if you want to use the latest plugin version. From the official documentation: |
In vendor/composer/installed.json one of my sites contains : |
At the moment, I successfully installed the CORS plugin by Offline on my v5.5 site |
Yep, I'll release a review release this weekend, just to make sure that everything is working for the Laravel 6 version. It should, but I want to make sure, and also want to patch some improvements to it. |
Super ! ;-) |
Hello Ricardo, do you have any news of the October side ? |
Hello. Not really, I'm really busy with others projects right now. I didn't had the time to explore it anymore. |
Ahoj Ricardo ! |
It was originally reported here.
It seems that the plugin isn't installing its dependencies somehow. I'm not sure if the issue is related to the plugin itself or the OctoberCMS.
The text was updated successfully, but these errors were encountered: