Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin torchvision version until #2248 is fixed #2252

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

irisliucy
Copy link
Contributor

No description provided.

@irisliucy irisliucy requested a review from a team as a code owner March 14, 2021 22:15
@irisliucy irisliucy requested review from krzentner and removed request for a team March 14, 2021 22:15
@mergify mergify bot requested review from a team, gitanshu and zequnyu and removed request for a team March 14, 2021 22:15
@irisliucy irisliucy requested review from a team and removed request for zequnyu and a team March 14, 2021 22:15
@mergify mergify bot requested review from a team and maliesa96 and removed request for a team March 14, 2021 22:16
Copy link
Contributor

@gitanshu gitanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend changing the commit message/PR title to reflect that this isn't a fix for #2248, but a workaround.

@mergify mergify bot requested a review from a team March 14, 2021 22:32
@gitanshu gitanshu changed the title pin torchvision version for fix #2248 Pin torchvision version until #2248 is fixed Mar 15, 2021
@gitanshu gitanshu mentioned this pull request Mar 15, 2021
6 tasks
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #2252 (a56bf53) into master (6d53e49) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2252      +/-   ##
==========================================
- Coverage   91.77%   91.25%   -0.53%     
==========================================
  Files         242      201      -41     
  Lines       17456    10977    -6479     
  Branches     2534     1371    -1163     
==========================================
- Hits        16021    10017    -6004     
+ Misses       1067      699     -368     
+ Partials      368      261     -107     
Impacted Files Coverage Δ
src/garage/sampler/utils.py 0.00% <0.00%> (-77.05%) ⬇️
src/garage/torch/algos/pearl.py 48.64% <0.00%> (-31.00%) ⬇️
src/garage/envs/multi_env_wrapper.py 79.51% <0.00%> (-14.60%) ⬇️
src/garage/tf/policies/policy.py 77.77% <0.00%> (-13.53%) ⬇️
src/garage/sampler/env_update.py 82.92% <0.00%> (-13.08%) ⬇️
src/garage/tf/algos/erwr.py 44.44% <0.00%> (-12.70%) ⬇️
src/garage/experiment/task_sampler.py 75.86% <0.00%> (-7.58%) ⬇️
src/garage/tf/_functions.py 68.85% <0.00%> (-5.98%) ⬇️
src/garage/plotter/plotter.py 62.06% <0.00%> (-5.46%) ⬇️
src/garage/experiment/meta_evaluator.py 88.63% <0.00%> (-5.12%) ⬇️
... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d53e49...a56bf53. Read the comment docs.

@mergify mergify bot requested a review from a team March 16, 2021 04:18
@gitanshu gitanshu closed this Mar 16, 2021
@gitanshu gitanshu reopened this Mar 16, 2021
@mergify mergify bot requested a review from a team March 16, 2021 05:28
@krzentner krzentner merged commit 2abb519 into master Mar 16, 2021
@krzentner krzentner deleted the pin-torchvision-fix branch March 16, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants