Disable the done signal.

[krzentner]

This fixes #43 in what I think is the cleanest way possible. There should probably be more discussion before we officially make a v2, but this might be of use to some people immediately.

This is definitely of interest to @avnishn and @lywong92 .

[krzentner]

Actually, this change is still largely incomplete, since I need to update all of the environment dictionaries. I'll probably have time to do that in a week's time.

[krzentner]

I believe there was some discussion that came to the conclusion that adding this option is fine?

If so, I believe this change can be merged in its current state.

[ryanjulian]

I think this could be made simpler by simply disabling it universally. We should also raise an exception in each env if someone steps past 150.

[krzentner]

I think this could be made simpler by simply disabling it universally.

Perhaps? I can certainly imagine someone wanting to be able to easily preserve the old behavior.

We should also raise an exception in each env if someone steps past 150.

I added that now. Since we probably want that check to be done in a base class method, I don't think there's much more simplicity to be had.

[ryanjulian]

I guess the missing context is that I discussed this with the authors last week and we decided that the simplest thing to do is to never send a done signal. This is consistent with the CoRL publication, and the current version is inconsistent.

Those needing a time limit implemented via termination (e.g. some on-policy implementations) will have to add it themselves.

I apologize for not specifically communicating about this (one of those many TODOs which never got visited).

[ryanjulian]

@krzentner is this ready to merge?

[krzentner]

@krzentner is this ready to merge?

Yes. It leaves the path length alone (150 in some envs, 200 in others), removes the done signal, and throws an exception when the path length is exceeded.