You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minor annoyance — currently the names of df's returned by sensmodel() default to the lambda max's, which results in a warning about column names if you feed it right into vismodel(). That necessitates the extra step of renaming to avoid the warning.
We could either (?):
(1) Add a names argument of some kind so that you can name the columns whatever you like when calling sensmodel()
(2) Make the defaults vismodel-friendly, at least up to tetrachromats. Beyond tetrachromats you could just leave it as-is I guess.
I'd lean toward (1), but open to anything.
The text was updated successfully, but these errors were encountered:
Just a thought, not sure about possible negative consequences: if the issue is just the warning, we could leverage the (currently unused) fact that sensmodel() objects have a special class and just bypass the warning in this case.
Minor annoyance — currently the names of df's returned by
sensmodel()
default to the lambda max's, which results in a warning about column names if you feed it right intovismodel()
. That necessitates the extra step of renaming to avoid the warning.We could either (?):
names
argument of some kind so that you can name the columns whatever you like when callingsensmodel()
I'd lean toward (1), but open to anything.
The text was updated successfully, but these errors were encountered: