Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensmodel() names #186

Closed
thomased opened this issue Jan 17, 2020 · 2 comments
Closed

sensmodel() names #186

thomased opened this issue Jan 17, 2020 · 2 comments

Comments

@thomased
Copy link
Collaborator

Minor annoyance — currently the names of df's returned by sensmodel() default to the lambda max's, which results in a warning about column names if you feed it right into vismodel(). That necessitates the extra step of renaming to avoid the warning.

We could either (?):

  • (1) Add a names argument of some kind so that you can name the columns whatever you like when calling sensmodel()
  • (2) Make the defaults vismodel-friendly, at least up to tetrachromats. Beyond tetrachromats you could just leave it as-is I guess.

I'd lean toward (1), but open to anything.

@Bisaloo
Copy link
Collaborator

Bisaloo commented Jan 18, 2020

Just a thought, not sure about possible negative consequences: if the issue is just the warning, we could leverage the (currently unused) fact that sensmodel() objects have a special class and just bypass the warning in this case.

@thomased
Copy link
Collaborator Author

A quick idea re: option (1) - 8ff03b0

I like the class idea too though — I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants