Skip to content

Commit 0ae7f41

Browse files
committed
Added: tests for both *nix and Windows.
1 parent be5ccef commit 0ae7f41

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = {
3030
rules: [
3131
{
3232
// Matches all PHP or JSON files in `resources/lang` directory.
33-
test: /resources(\\|\/)lang.+\.(php|json)$/,
33+
test: /resources[\\\/]lang.+\.(php|json)$/,
3434
loader: 'laravel-localization-loader',
3535
}
3636
]
@@ -47,7 +47,7 @@ mix.webpackConfig({
4747
rules: [
4848
{
4949
// Matches all PHP or JSON files in `resources/lang` directory.
50-
test: /resources(\\|\/)lang.+\.(php|json)$/,
50+
test: /resources[\\\/]lang.+\.(php|json)$/,
5151
loader: 'laravel-localization-loader',
5252
}
5353
]

tests/fixtures/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
var message = require('./resources/lang/en/messages.php')
2-
console.log(message);

tests/loader.test.js

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,22 @@ describe('laravel-localization-loader', () => {
2929
return runWebpack(testDir.name, {
3030
entry: path.join(__dirname, './fixtures/resources/lang/en/messages.php'),
3131
})
32-
.then((result) => {
32+
.then((output) => {
33+
const result = require(output)
3334
expect(result).toBeDefined()
3435
expect(result).toHaveProperty('string', 'Rubens')
3536
expect(result).toHaveProperty('number', 123)
3637
expect(result).toHaveProperty('parent.child', 'Mariuzzo')
3738
expect(result).toHaveProperty('escape', '\'escaped\'')
3839
})
3940
})
41+
4042
it('should load JSON Laravel translation file', () => {
4143
return runWebpack(testDir.name, {
4244
entry: path.join(__dirname, './fixtures/resources/lang/en/messages.json'),
4345
})
44-
.then((result) => {
46+
.then((output) => {
47+
const result = require(output)
4548
expect(result).toBeDefined()
4649
expect(result).toHaveProperty('string', 'Rubens')
4750
expect(result).toHaveProperty('number', 123)
@@ -74,7 +77,7 @@ function runWebpack(outputDir, config) {
7477
module: {
7578
rules: [
7679
{
77-
test: /resources\/lang.+\.(php|json)$/,
80+
test: /resources[\\\/]lang.+\.(php|json)$/,
7881
loader: 'laravel-localization-loader',
7982
}
8083
]
@@ -98,11 +101,13 @@ function runWebpack(outputDir, config) {
98101
return reject(error)
99102
}
100103

104+
const output = `${outputDir}/translation.js`
105+
101106
// Remove webpack output from Node require's cache.
102-
delete require.cache[`${outputDir}/translation.js`]
107+
delete require.cache[output]
103108

104-
// Resolve with the recente webpack's output.
105-
return resolve(require(`${outputDir}/translation.js`))
109+
// Resolve with the recent webpack's output.
110+
return resolve(output)
106111
})
107112
})
108113
}

0 commit comments

Comments
 (0)