Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, REF] Adds dataset fetchers and refactors loaders #7

Merged
merged 4 commits into from
Feb 26, 2019

Conversation

rmarkello
Copy link
Owner

@rmarkello rmarkello commented Feb 26, 2019

Adds ability to download genetics data in addition to study data. Renames a few functions to make the API a bit more consistent across fetchers and refactors the entire pypmi.datasets submodule to be more consolidated.

Adds ability to download genetics data in addition to study data. Also
renames a few functions
Reduces submodule down to two main files: fetchers.py and loaders.py,
containing all the relevant information for downloading and loading data
available through the PPMI.
@rmarkello rmarkello changed the title [ENH] Adds genetics data fetchers [ENH, REF] Adds dataset fetchers and refactors loaders Feb 26, 2019
@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #7 into master will decrease coverage by 2.52%.
The diff coverage is 31.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   46.03%   43.51%   -2.53%     
==========================================
  Files          16       12       -4     
  Lines         719      717       -2     
==========================================
- Hits          331      312      -19     
- Misses        388      405      +17
Impacted Files Coverage Δ
pypmi/tests/conftest.py 100% <100%> (ø) ⬆️
pypmi/datasets/_info.py 100% <100%> (ø)
pypmi/datasets/__init__.py 100% <100%> (ø) ⬆️
pypmi/__init__.py 100% <100%> (ø) ⬆️
pypmi/tests/test_datasets_fetchers.py 77.77% <100%> (ø)
pypmi/datasets/loaders.py 13.04% <13.04%> (ø)
pypmi/datasets/fetchers.py 77.23% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c64ab8...bf993cf. Read the comment docs.

@rmarkello rmarkello merged commit 313ed80 into master Feb 26, 2019
@rmarkello rmarkello deleted the update/fetchers branch February 26, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants