Colorscheme light/dark

[lvstb]

Is there a way to make the light variant of the colorscheme visible in the list of colorschemes?
Like for example catpuccing where you have 4 variants: catpuccing-mocha, catpuccin-latte.,...
It would be nice to have onenord, onenord-light.

Right now there is only onenord and depending of the config you give it (via theme = dark/light) it will be dark or light.

Reasoning behind this is that it would make it easy to switch between them depending the time of the day.

[rmehri01]

Hey! This is what we had before but I wasn't sure of the interactions with background at the time but I think this is doable, it seems that tokyonight does something similar.

[lvstb]

Hey!
Great to see you responding and commiting this quick :-D
Is it possible there is still something not 100%
Im now able to quickly switch between dark and light (thanks), but for example my telescope and wilder menu is not switching to light but remains dark (i did the test with other themes and there this just works).

[rmehri01]

No problem! Hmm that's strange, for me telescope changes fine but I think I see something similar with notify where the notification is in the previous color if it's already in progress but then the next notification will be the right color. But I also get this with other themes like tokyonight, so I don't think its exclusive to this theme.

Do you mean that the telescope colors don't change at all, even if you open a new one?

[lvstb]

Indeed, opening a new telescope window or the autocomplette window,.... they all stay in the dark theme even when opening a new one.

[rmehri01]

This doesn't happen for me when using the default config or the colors provided by require("onenord.colors").load(), I think it has to do with your config? I noticed you are overriding some groups with custom colors and these won't change when switching to the light theme. I suppose it could be possible to add theme specific customizations if it would be helpful, maybe something like:

  custom_highlights = {
    dark = { ... },
    light = { ... },
  },

And similar with the custom colors.

[lvstb]

You are correct, it was my config.
Thanks!

[rmehri01]

No problem! Feel free to let me know if you think the customizations per theme would be helpful or not 😄

[hakkeroid]

  custom_highlights = {
    dark = { ... },
    light = { ... },
  },

@rmehri01 I don't mean to necrobump an already closed issue. However, since you had this feature on your mind already I would like to add my support for it. The dark background color is a bit too light for my taste and I can't override it without breaking the light version as well.

[rmehri01]

Hey! I just pushed a commit that should make this work but let me know if you run into any trouble 😄

[hakkeroid]

Man, that was fast and works like a charm. Thank you a lot!