-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optatmo_psf wavefront based PSF #152
Draft
aaronroodman
wants to merge
26
commits into
main
Choose a base branch
from
optatmo3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mike, you had made some edits to devel/time_optatmo_mkimage.py, which included removing this code:
params has all the information about how this star was made, and my understanding is that belonged in the StarFit object as above. Is that not correct, and if not where should that information go |
Merge branch 'main' into optatmo3
Merge branch 'pupil_plane_scale' into optatmo3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has optatmo_psf included. Note that the only unit test included just makes the PSF class, nothing more is implemented yet.
In the devel area are two scripts with high level but lengthy tests of optatmo_psf:
python time_optatmo_mkimage.py psf_optatmo_time.yaml
uses the PSF class to make a focal plane's worth of stars, writing these out to a pickle file. By default no extra atmosphere is added, only a constant atmosphere.python time_optatmo_fit.py psf_optatmo_time.yaml
then reads in the stars and fits them. The fit takes 45 minutes on an old linux machine, and should yield fit results with the same values as used to make the stars. There is no checking implemented, only printout.I don't see where to label this PR a work in progress, but obviously thats what this is.
I think it would be great if you can give optatmo_psf a high level review, especially to see if it is implementing the PSF interface correctly. Issues that I know need work are a) how to store the optical fit parameters and b) how to write out the stars into a PIFF file and c) how to write out the fit output in a PIFF file.