You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The __init__ of key exchange protocol classes called by X25519 accept a key_exchange_type key-word argument &, for all except the 2DH client class, a my_identity_key argument. However, the latter is always an instance of the former. This is an API mistake, as accepting both is redundant & facilitates inconsistencies / type unsafety.
The DoubleDiffieHellmanClient, DoubleDiffieHellmanServer, TripleDiffieHellmanClient, & TripleDiffieHellmanServer classes should be instantiable after accepting the argument of either key_exchange_type, or an instance of that type as my_identity_key, but not both. Types should be checked with protocols from the Typing class.
The text was updated successfully, but these errors were encountered:
Description
The
__init__
of key exchange protocol classes called byX25519
accept akey_exchange_type
key-word argument &, for all except the 2DH client class, amy_identity_key
argument. However, the latter is always an instance of the former. This is an API mistake, as accepting both is redundant & facilitates inconsistencies / type unsafety.Links to relevant files:
Expected behavior
The
DoubleDiffieHellmanClient
,DoubleDiffieHellmanServer
,TripleDiffieHellmanClient
, &TripleDiffieHellmanServer
classes should be instantiable after accepting the argument of eitherkey_exchange_type
, or an instance of that type asmy_identity_key
, but not both. Types should be checked with protocols from theTyping
class.The text was updated successfully, but these errors were encountered: