Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to use i18n for recent Cucumber versions #262

Closed
rdlopes opened this issue Jul 23, 2022 · 2 comments
Closed

Be able to use i18n for recent Cucumber versions #262

rdlopes opened this issue Jul 23, 2022 · 2 comments
Labels
enhancement
Milestone
3.9.0

Comments

@rdlopes
Copy link
Contributor

rdlopes commented Jul 23, 2022

Hi Raphaël, hope you're well,
I'm using the French i18n feature of Cukedoctor but unfortunately, Cucumber for newer versions has stopped supporting comments in JSON features, leaving us with no options in Cukedoctor but to define our own custom resource bundle.

In order to favor reuse of Cukedoctor i18n resource bundles, I've added #261 PR for using the @language-<lang> tag in gherkin features.
@rdlopes
Copy link
Contributor Author

rdlopes commented Jul 24, 2022

So the good PR is #264 since I couldn't refrain myself in the old one to clean everything. My OCD - not sorry 😝

@rmpestano rmpestano added this to the 3.9.0 milestone Jul 30, 2022
rmpestano pushed a commit that referenced this issue Jul 30, 2022
@rdlopes
feat(converter): add a cukedoctor language tag @language-<language> (#…
5ac98ff 
…264)

refs #262
@rmpestano
Copy link
Owner

Fixed by #264, thanks again @rdlopes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.9.0
Development

No branches or pull requests
2 participants
@rdlopes @rmpestano