-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/lib restructure #37
Conversation
name |
Can you make it so that example imports crates it need to use. Now in example contract the rmrk crate is included which then includes all other. |
IMO it's better to keep to a single entry crate (much like ink! and openbrush) rather than users having to depend on crates individually. Maybe we could put crates behind features flags so users only pull in the sub-crates they need? We could have something along the lines of: rmrk = { path = "..", default-features = false, features = ["nesting", "minting", "base", "equippable", "multiasset"] } Maybe it makes more sense to decide what logical groups of crates are actual features (ie. equippable actually depends on multiasset and nesting). Such as: default = ["common", "minting"]
equippable = ["nesting", "equippable", "multiasset"]
# etc... |
@boyswan agree. Let's create features with logical group of crate as you mentioned and keep a single entry crate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.