Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep RMRK errors intact rather than downcasting to Strings and wrapping in
PSP34::Custom
.PSP34
andRMRK
errors@Maar-io made a good point about PSP34 potentially being a common interface between external contracts, so having our own error type produces are larger API surface area to cover. One way to manage this is to also provide a
From<Error> for PSP34Error
to allow easy conversions if necessary.