Fix Jack thread terminate issues when using multiple output audio interfaces #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Jack is using multiple inputs, the minimum minimal of stereo outputs is two, as at least two FX channels will be generated. Also, when the number of audio channels is odd, fluidsynth (tested with version 2.1.1 and 2.1.5) ends having some problem setting the connections and causing the Jack thread to terminate. So, ensure that the number of channels will be an even number. While here, disable setting the number of channels when Jack is set to use just one stereo output channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Jack is using multiple inputs, the minimum minimal of stereo outputs is two, as at least two FX channels will be generated.
Also, when the number of audio channels is odd,
fluidsynth(tested with version 2.1.1 and 2.1.5) ends having some problem setting the connections and causing the Jack thread to terminate.So, ensure that the number of channels will be an even number.
While here, disable setting the number of channels when Jack is set to use just one stereo output channel.
PS.: Please notice that I forked
Qsynthfrom:https://git.code.sf.net/p/qsynth/code
Which has two extra patches.