- MIDI clip editor (aka. piano-roll): Transport/Step/Note/Backward,

  Formard, now plays the step-selected notes, provided send/Preview
  is on and playback is not rolling. (REFACTORED)

Author: rncbc

src/qtractorMidiEditorForm.cpp

@@ -65,6 +65,8 @@
 #include <QLabel>
 #include <QUrl>
 
+#include <QTimer>
+
 #if QT_VERSION < QT_VERSION_CHECK(5, 11, 0)
 #define horizontalAdvance  width
 #endif
@@ -2157,8 +2159,6 @@ void qtractorMidiEditorForm::transportStepNoteBackward (void)
 
 	const bool bSendNotes
 		= m_pMidiEditor->isSendNotesEx();
-	const unsigned long iMaxDuration
-		= pSession->ticksPerBeat();
 
 	unsigned long iPlayHead = pSession->playHead();
 	qtractorMidiSequence *pSeq = m_pMidiEditor->sequence();
@@ -2193,8 +2193,9 @@ void qtractorMidiEditorForm::transportStepNoteBackward (void)
 				if (pEvent->type() == eventType) {
 					m_pMidiEditor->selectEvent(pEvent);
 					if (bSendNotes && eventType == qtractorMidiEvent::NOTEON) {
-						sendNoteEx(pEvent->note(), pEvent->velocity(),
-							qMax(pEvent->duration(), iMaxDuration));
+						sendNoteEx(pEvent->note(),
+							pEvent->velocity(),
+							pEvent->duration());
 					}
 				}
 				pEvent = pEvent->prev();
@@ -2220,8 +2221,6 @@ void qtractorMidiEditorForm::transportStepNoteForward (void)
 
 	const bool bSendNotes
 		= m_pMidiEditor->isSendNotesEx();
-	const unsigned long iMaxDuration
-		= pSession->ticksPerBeat();
 
 	unsigned long iPlayHead = pSession->playHead();
 	qtractorMidiSequence *pSeq = m_pMidiEditor->sequence();
@@ -2253,8 +2252,9 @@ void qtractorMidiEditorForm::transportStepNoteForward (void)
 				if (pEvent->type() == eventType) {
 					m_pMidiEditor->selectEvent(pEvent);
 					if (bSendNotes && eventType == qtractorMidiEvent::NOTEON) {
-						sendNoteEx(pEvent->note(), pEvent->velocity(),
-							qMax(pEvent->duration(), iMaxDuration));
+						sendNoteEx(pEvent->note(),
+							pEvent->velocity(),
+							pEvent->duration());
 					}
 				}
 				pEvent = pEvent->next();
@@ -2328,20 +2328,27 @@ void qtractorMidiEditorForm::sendNote ( int iNote, int iVelocity, bool bForce )
 void qtractorMidiEditorForm::sendNoteEx (
 	int iNote, int iVelocity, unsigned long iDuration )
 {
-	qtractorMidiClip *pMidiClip = m_pMidiEditor->midiClip();
-	if (pMidiClip == nullptr)
-		return;
-
-	qtractorTrack *pTrack = pMidiClip->track();
-	if (pTrack == nullptr)
-		return;
-
-	qtractorMidiBus *pMidiBus
-		= static_cast<qtractorMidiBus *> (pTrack->outputBus());
-	if (pMidiBus == nullptr)
+	qtractorSession *pSession = qtractorSession::getInstance();
+	if (pSession == nullptr)
 		return;
 
-	pMidiBus->sendNoteEx(pTrack, iNote, iVelocity, iDuration);
+	const unsigned int srate = pSession->sampleRate();
+	if (srate > 0) {
+		// Direct note-on...
+		sendNote(iNote, iVelocity, false);
+		// Schedule  note-off...
+		const unsigned long f1 = pSession->playHead();
+		qtractorTimeScale::Cursor cursor(pSession->timeScale());
+		qtractorTimeScale::Node *pNode = cursor.seekFrame(f1);
+		const unsigned long iMaxDuration
+			= pSession->ticksPerBeat() * pNode->beatsPerBar2();
+		const unsigned long t1 = pNode->tickFromFrame(f1);
+		const unsigned long t2 = t1 + qMin(iDuration, iMaxDuration);
+		pNode = cursor.seekTick(t2);
+		const unsigned long f2 = pNode->frameFromTick(t2);
+		const unsigned int msecs = (1000 * (f2 - f1)) / srate;
+		QTimer::singleShot(msecs, [=]{ sendNote(iNote, 0, false); });
+	}
 }
 
 

src/qtractorMidiEngine.cpp

@@ -4782,84 +4782,6 @@ void qtractorMidiBus::sendNote (
 }
 
 
-// Scheduled MIDI note helper.
-void qtractorMidiBus::sendNoteEx (
-	qtractorTrack *pTrack, int iNote, int iVelocity, unsigned long iDuration ) const
-{
-	qtractorSession *pSession = pTrack->session();
-	if (pSession == nullptr)
-		return;
-
-	// We always need our MIDI engine reference...
-	qtractorMidiEngine *pMidiEngine
-		= static_cast<qtractorMidiEngine *> (engine());
-	if (pMidiEngine == nullptr)
-		return;
-
-	// Don't do anything else if engine
-	// has not been activated...
-	snd_seq_t *pAlsaSeq = pMidiEngine->alsaSeq();
-	if (pAlsaSeq == nullptr)
-		return;
-
-	const unsigned short iChannel = pTrack->midiChannel();
-
-#ifdef CONFIG_DEBUG_0
-	qDebug("qtractorMidiBus[%p]::sendNoteEx(%d, %d, %d, %lu)",
-		this, iChannel, iNote, iVelocity, iDuration);
-#endif
-
-	// Initialize sequencer event...
-	snd_seq_event_t ev;
-	snd_seq_ev_clear(&ev);
-
-	// Addressing...
-	snd_seq_ev_set_source(&ev, m_iAlsaPort);
-	snd_seq_ev_set_subs(&ev);
-
-	// The event will be direct...
-	const unsigned long tick
-		= pSession->timep(pMidiEngine->queueTime());
-	snd_seq_ev_set_dest(&ev,
-		pMidiEngine->alsaClient(), m_iAlsaPort);
-	snd_seq_ev_schedule_tick(&ev,
-		pMidiEngine->alsaQueue(), 0, tick);
-
-	// Set event parameters...
-	ev.type = SND_SEQ_EVENT_NOTE;
-	ev.data.note.channel  = iChannel;
-	ev.data.note.note     = iNote;
-	ev.data.note.velocity = iVelocity;
-	ev.data.note.duration = iDuration;
-	snd_seq_event_output(pAlsaSeq, &ev);
-
-	// Do it for the MIDI plugins too...
-	const unsigned long t1 = pSession->playHead();
-	qtractorTimeScale::Cursor cursor(pSession->timeScale());
-	qtractorTimeScale::Node *pNode = cursor.seekFrame(t1);
-	const unsigned long iTime = pNode->tickFromFrame(t1);
-	const unsigned long iTimeOff = iTime + (iDuration - 1);
-	pNode = cursor.seekTick(iTimeOff);
-	const unsigned long t2 = pNode->frameFromTick(iTimeOff);
-	if ((pTrack->pluginList())->midiManager())
-		(pTrack->pluginList())->midiManager()->queued(&ev, t1, t2);
-	if (pluginList_out() && pluginList_out()->midiManager())
-		(pluginList_out()->midiManager())->queued(&ev, t1, t2);
-
-	pMidiEngine->flush();
-
-	// Bus/track output monitoring...
-	// Bus output monitoring...
-	if (m_pOMidiMonitor)
-		m_pOMidiMonitor->enqueue(qtractorMidiEvent::NOTEON, iVelocity);
-	// Track output monitoring...
-	qtractorMidiMonitor *pMidiMonitor
-		= static_cast<qtractorMidiMonitor *> (pTrack->monitor());
-	if (pMidiMonitor)
-		pMidiMonitor->enqueue(qtractorMidiEvent::NOTEON, iVelocity);
-}
-
-
 // Direct SysEx helpers.
 void qtractorMidiBus::sendSysex (
 	unsigned char *pSysex, unsigned int iSysex ) const

src/qtractorMidiEngine.h

@@ -538,10 +538,6 @@ class qtractorMidiBus : public qtractorBus
 	void sendNote(qtractorTrack *pTrack,
 		int iNote, int iVelocity, bool bForce) const;
 
-	// Schedule MIDI note helper.
-	void sendNoteEx(qtractorTrack *pTrack,
-		int iNote, int iVelocity, unsigned long iDuration) const;
-
 	// Direct SysEx helpers.
 	void sendSysex(unsigned char *pSysex, unsigned int iSysex) const;
 	void sendSysexList() const;