Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --client-name option to samplv1_jack #31

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Conversation

asmuth
Copy link
Contributor

@asmuth asmuth commented Aug 30, 2020

Hey Rui,

first of all thank you for all the brilliant open source software. I very much enjoyed using samplv1 and drumkitv1 on the last weekend.

Attached is a pull request that adds a new option called --client-name to the samplv1_jack program. This option is useful to me as it allows me to start multiple instances of samplv1 and automatically connect them up to other programs using the jack_connect tool. I tried to make the change fit in with the style of the project, but I am not quite sure about the capitalization and naming convention for members.

all the best

@rncbc
Copy link
Owner

rncbc commented Aug 31, 2020

looks good, thanks
later I'll get to adapt to all the others v1s, if you don't mind.
cheers

@rncbc rncbc merged commit 3495ff1 into rncbc:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants