Add a --client-name option to samplv1_jack #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Rui,
first of all thank you for all the brilliant open source software. I very much enjoyed using samplv1 and drumkitv1 on the last weekend.
Attached is a pull request that adds a new option called
--client-name
to thesamplv1_jack
program. This option is useful to me as it allows me to start multiple instances of samplv1 and automatically connect them up to other programs using thejack_connect
tool. I tried to make the change fit in with the style of the project, but I am not quite sure about the capitalization and naming convention for members.all the best