Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract team from the permalink #23

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Conversation

rneatherway
Copy link
Owner

No description provided.

@rneatherway rneatherway force-pushed the rneatherway/team-from-permalink branch from 4377162 to 1c42ac3 Compare December 9, 2022 13:44
@mwarkentin
Copy link

Seems like it's working on this branch:

image

Do you think it makes sense to still support -t --team in the CLI in case you want to use the tool to fetch from multiple workspaces (without having to run the config set each time)?

@rneatherway
Copy link
Owner Author

Glad it's working for you 😄

Do you think it makes sense to still support -t --team in the CLI in case you want to use the tool to fetch from multiple workspaces (without having to run the config set each time)?

Because you have to provide a permalink for each thread you want to fetch and that link contains the team name I don't think there is any need for the configuration or CLI option in the end. Sorry to have missed that at the start, which caused you to spend time on your PR.

I'll do a new release of the extension with this fix on Monday.

@mwarkentin
Copy link

Because you have to provide a permalink for each thread you want to fetch and that link contains the team name I don't think there is any need for the configuration or CLI option in the end.

Ooh, gotcha.. that makes sense, now I understand what you were doing here. Sounds great, looking forward to trying it out!

@mwarkentin mwarkentin mentioned this pull request Dec 10, 2022
@rneatherway rneatherway merged commit 6a396dc into main Dec 12, 2022
@rneatherway rneatherway deleted the rneatherway/team-from-permalink branch December 12, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants