Add verbose flag #178
Add verbose flag #178
Conversation
system needs rebooted
|
I'm open to other ways to do this like a |
There was a problem hiding this comment.
Thanks for the contribution!
I agree that the output if nothing needs to be done is unnecessary (I probably had it as a debug info in the beginning and just left it).
I'm open to other ways to do this like a --verbose or moving the println!(..) to info!(...) but wanted to make the changes as small as possible.
Currently I'd slightly prefer to disable the unnecessary output by default and add a --verbose flag.
What is your opinion?
src/kernel.rs
Outdated
| let should_reboot = running_kernel_version != &cleaned_kernel_version; | ||
| if !self.quiet || should_reboot { |
There was a problem hiding this comment.
According to https://tldp.org/LDP/abs/html/standard-options.html --quiet is expected to "suppress stdout".
Here we only suppress it if should_reboot is false. But of course this behavior makes a lot of sense given the purpose mentioned by you.
There was a problem hiding this comment.
I think that's fine. I wasn't sure if there was a reason for that output, so I started off w/ a minimal change. Do you want anything else printed with --verbose?
There was a problem hiding this comment.
Do you want anything else printed with --verbose?
We could output some information on the various checkers, but I for myself am mostly interested in the kernel version. I sometimes use it as an alternative to uname -r with my rab alias to check which kernel variant I booted.
So for now I think we are fine with the just having the old behavior when passing --verbose and be more silent by default.
|
What would be nice as well would be a CHANGELOG entry. But I can also do it myself before releasing. |
I can take care of that this evening! |
package updated if verbose flag is set. Continue to display kernel version even when an update is not needed.
|
Okay, maybe not exactly how you wanted it (I can adjust if needed) but: if verbose is not set, only notify that a reboot/session reload is requited. Withe verbose flag, print the kernel version (always) and package version (if an update is required). I also added a changelog entry for 1.7.2 with this PR. Thanks for being kind, its my first PR! |
Lets see how it works out in practice like this.
I adapted it to be for "Unreleased"
You're welcome! Thanks for contributing 🙂 |
Add a
-v/--verboseflag so that kernel version isn't printed every time pacman updates or for MOTD.