Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android):update MarkerView position on camera move #1735

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

ufukbozkurt
Copy link

android fix for issue #1546

update every marker in onCameraMove event at MapView.

@mfazekas
Copy link
Contributor

@ufukbozkurt thanks looks nice, can you post perhaps a video of before after, so improvement is visible?!

@schiller-manuel
Copy link
Contributor

I ran the Annotation example of the example app to check the difference:

before the patch:
https://user-images.githubusercontent.com/6340397/153650140-70509359-917d-4aa3-ae06-06a6181f6e64.mp4

after the patch:
https://user-images.githubusercontent.com/6340397/153650154-c5dd01a5-a11b-43f9-bca4-3a105e6b77df.mp4

LGTM!

@mfazekas mfazekas merged commit 8390e0a into rnmapbox:master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants