Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for iOS 12.4 with Mapbox Maps SDK v11 #3433

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Support for iOS 12.4 with Mapbox Maps SDK v11 #3433

merged 1 commit into from
Apr 7, 2024

Conversation

hexadecy
Copy link
Contributor

@hexadecy hexadecy commented Mar 25, 2024 •
edited
Loading

Description

Fixes #3432

[!] CocoaPods could not find compatible versions for pod "rnmapbox-maps":
  In Podfile:
    rnmapbox-maps (from `../node_modules/@rnmapbox/maps`)

Specs satisfying the `rnmapbox-maps (from `../node_modules/@rnmapbox/maps`)` dependency were found, but they required a higher minimum deployment target.
  • Change the requirement of Mapbox v11 from iOS 13.0 down to 12.4
  • Also changed the documentation to encourage supporting lower iOS versions. Each react-native release has a minimum predefined that we should use.

I don't see any downside to lowering the requirement yet.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code by running yarn generate in the root folder
  • I have tested the new feature on /example app without Flipper.
    • In V11 mode/ios with React-Native 0.72.11 target ios 12.4
    • In V10 mode/ios with React-Native 0.72.11 target ios 12.4
    • In V11 mode/ios with React-Native 0.73.0 target ios 13.4
    • In V10 mode/ios with React-Native 0.73.0 target ios 13.4
    • In New Architecture V11 mode/ios
    • In V11 mode/android
    • In V10 mode/android
    • In New Architecture V11 mode/android

@mfazekas
Copy link
Contributor

@hexadecy thanks for the PR, can you please separate them?

mfazekas
mfazekas requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls separate the PR

example/ios/Podfile Outdated Show resolved Hide resolved
mfazekas
mfazekas reviewed Mar 26, 2024
View reviewed changes
example/.java-version Outdated Show resolved Hide resolved
@hexadecy hexadecy temporarily deployed to CI with Mapbox Tokens March 26, 2024 18:35 — with GitHub Actions Inactive
@hexadecy hexadecy had a problem deploying to CI with Mapbox Tokens March 26, 2024 18:35 — with GitHub Actions Failure
@hexadecy hexadecy temporarily deployed to CI with Mapbox Tokens March 26, 2024 18:35 — with GitHub Actions Inactive
@hexadecy hexadecy had a problem deploying to CI with Mapbox Tokens March 26, 2024 18:35 — with GitHub Actions Failure
@hexadecy hexadecy temporarily deployed to CI with Mapbox Tokens March 26, 2024 18:35 — with GitHub Actions Inactive
@hexadecy hexadecy temporarily deployed to CI with Mapbox Tokens March 26, 2024 18:35 — with GitHub Actions Inactive
@hexadecy hexadecy requested a review from mfazekas April 3, 2024 17:58
@hexadecy
Copy link
Contributor Author

hexadecy commented Apr 3, 2024

pls separate the PR

Done

@mfazekas mfazekas merged commit b76c000 into rnmapbox:main Apr 7, 2024
8 of 10 checks passed
@hexadecy hexadecy deleted the fix/ios-12-support branch April 21, 2024 18:51
@mfazekas mfazekas mentioned this pull request Apr 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfazekas mfazekas mfazekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for iOS 12.4 with Mapbox Maps SDK v11
2 participants
@hexadecy @mfazekas