Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow exceptions beyond the FFI boundary #839

Closed
dewyatt opened this issue Apr 27, 2019 · 0 comments · Fixed by #1212
Closed

Do not allow exceptions beyond the FFI boundary #839

dewyatt opened this issue Apr 27, 2019 · 0 comments · Fixed by #1212
Assignees
@dewyatt
Labels
enhancement
Milestone
v0.14.0

Comments

@dewyatt
Copy link
Contributor

dewyatt commented Apr 27, 2019

Description

As we continue to transition to a more C++ based codebase, we are going to end up using things that may throw exceptions. We need to ensure that we catch exceptions within the FFI functions.

We can look at Botan's ffi_guard_thunk as one possible solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dewyatt dewyatt

Labels
enhancement
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

Add exception guard to FFI boundary. rnpgp/rnp
2 participants
@dewyatt @ni4