Add exception guard to FFI boundary. #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses function try blocks to prevent C++ exceptions from propagating across the FFI boundary. Some functions which return direct values (rather than error codes) and do not throw are left as-is.
dewyatt
force-pushed
the
dewyatt-839-exceptions-ffi-boundary
branch
from
b27cc72
to
56cd0ff
Compare
Added some tests. It only tests against a single FFI function really but it does test a few different exception types. |
ni4
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
LGTM, thanks, @dewyatt. But let's wait for @antonsviridenko comments as he was first to review.
|
@antonsviridenko Feel free to rebase and merge once there are two or more approvals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses function try blocks to prevent C++ exceptions from propagating
across the FFI boundary. Some functions which return direct values
(rather than error codes) and do not throw are left as-is.
For now it just prints directly to
stderrand uses a format similar toRNP_LOG, which I think is a good compromise considering that it should be a very rare occurrence.Fixes #839