Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix GHA cache for macOS #1056

Merged
merged 3 commits into from
Jan 23, 2020
Merged

ci: Fix GHA cache for macOS #1056

merged 3 commits into from
Jan 23, 2020

Conversation

dewyatt
Copy link
Contributor

@dewyatt dewyatt commented Jan 23, 2020

No description provided.

@dewyatt dewyatt requested review from ronaldtse and ni4 January 23, 2020 04:45
@codecov
Copy link

codecov bot commented Jan 23, 2020 •
edited
Loading

Codecov Report

Merging #1056 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1056      +/-   ##
=========================================
- Coverage   82.72%   82.7%   -0.03%     
=========================================
  Files          77      77              
  Lines       28089   28089              
=========================================
- Hits        23238   23230       -8     
- Misses       4851    4859       +8
Impacted Files Coverage Δ
src/librepgp/stream-parse.cpp 77.78% <0%> (-0.6%) ⬇️
src/librepgp/stream-write.cpp 78.93% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95cd0d7...bdd1af8. Read the comment docs.

ronaldtse
ronaldtse approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - CI change so merging now. Thanks @dewyatt !

@ronaldtse ronaldtse merged commit 2d28d7d into master Jan 23, 2020
@ronaldtse ronaldtse deleted the dewyatt-ci-fix-gha-cache-macos branch January 23, 2020 07:29
@dewyatt dewyatt mentioned this pull request Jan 23, 2020
Closed
@ni4 ni4 added this to the v0.14.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

@ni4 ni4 Awaiting requested review from ni4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dewyatt @ronaldtse @ni4