-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to export key revocation. #1066
Conversation
28824d8
to
8c02730
Compare
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
=========================================
+ Coverage 82.96% 83.06% +0.1%
=========================================
Files 76 76
Lines 28482 28748 +266
=========================================
+ Hits 23629 23880 +251
- Misses 4853 4868 +15
Continue to review full report at Codecov.
|
4243bb0
to
e4a9468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read thoroughly the unit test. Why don't you use rnp_output_to_null
?
c99d6a3
to
223e81e
Compare
@dewyatt @ronaldtse Could you please review this? I wasn't able to satisfy codecov however I tried as hard as possible. |
223e81e
to
e261a08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is part of work on key revocation(s) (issue #1005), and fixes #1007
It implements low-level functionality to generate key revocation certificate, FFI function to export such certificate and rnpkeys CLI command
--export-rev
and options--rev-type, --rev-reason
to work with this.