Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to export key revocation. #1066

Merged
merged 10 commits into from
Feb 16, 2020
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Feb 9, 2020

This PR is part of work on key revocation(s) (issue #1005), and fixes #1007
It implements low-level functionality to generate key revocation certificate, FFI function to export such certificate and rnpkeys CLI command --export-rev and options --rev-type, --rev-reason to work with this.

@codecov
Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #1066 into master will increase coverage by 0.1%.
The diff coverage is 83.24%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1066     +/-   ##
=========================================
+ Coverage   82.96%   83.06%   +0.1%     
=========================================
  Files          76       76             
  Lines       28482    28748    +266     
=========================================
+ Hits        23629    23880    +251     
- Misses       4853     4868     +15
Impacted Files Coverage Δ
src/lib/pgp-key.cpp 80.22% <ø> (ø) ⬆️
src/tests/ffi.cpp 98.78% <ø> (+0.02%) ⬆️
src/tests/exportkey.cpp 100% <100%> (ø) ⬆️
src/tests/generatekey.cpp 96.78% <100%> (ø) ⬆️
src/tests/issues/1030.cpp 100% <100%> (ø) ⬆️
src/librepgp/stream-packet.cpp 77.06% <100%> (ø) ⬆️
src/tests/streams.cpp 98.82% <100%> (ø) ⬆️
src/librekey/key_store_pgp.cpp 68.42% <100%> (+0.15%) ⬆️
src/librepgp/stream-key.cpp 66.54% <52.08%> (-0.92%) ⬇️
src/rnpkeys/rnpkeys.cpp 65.71% <90.47%> (+3.34%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a39e2b...e261a08. Read the comment docs.

src/lib/rnp.cpp Show resolved Hide resolved
@ni4 ni4 force-pushed the ni4-1005-export-key-revocation branch 2 times, most recently from 4243bb0 to e4a9468 Compare February 10, 2020 16:51
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read thoroughly the unit test. Why don't you use rnp_output_to_null?

src/tests/ffi.cpp Outdated Show resolved Hide resolved
src/tests/ffi.cpp Outdated Show resolved Hide resolved
@ni4 ni4 force-pushed the ni4-1005-export-key-revocation branch 3 times, most recently from c99d6a3 to 223e81e Compare February 12, 2020 17:13
@ni4
Copy link
Contributor Author

ni4 commented Feb 12, 2020

@dewyatt @ronaldtse Could you please review this? I wasn't able to satisfy codecov however I tried as hard as possible.

@ni4 ni4 force-pushed the ni4-1005-export-key-revocation branch from 223e81e to e261a08 Compare February 14, 2020 10:45
Copy link
Contributor

@dewyatt dewyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ronaldtse ronaldtse merged commit 094b132 into master Feb 16, 2020
@ronaldtse ronaldtse deleted the ni4-1005-export-key-revocation branch February 16, 2020 02:33
@ni4 ni4 added this to the v0.14.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to create/export prepared/inactive revocation statement
4 participants