-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install automake for macos GHA. #1096
Conversation
@dewyatt Is this a correct way and place in script to install automake? And, still have issues with ruby-rnp. |
@ronaldtse First one is because of test key expiration, I will make a separate PR fixing this. The second one is something on the ruby side, I guess. Did a PR in attempt to fix that here: rnpgp/ruby-rnp#67 |
a65108a
to
e2bc202
Compare
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
- Coverage 83.20% 83.17% -0.03%
==========================================
Files 76 76
Lines 29070 29070
==========================================
- Hits 24187 24180 -7
- Misses 4883 4890 +7
Continue to review full report at Codecov.
|
ci/before_install.sh
Outdated
@@ -5,6 +5,7 @@ set -ex | |||
|
|||
macos_install() { | |||
[ "${CI-}" = true ] || brew bundle | |||
brew install automake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of this just add it to the top-level Brewfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait I just realized it's already in there -_-. Must be something else going on here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working on getting CI stable again with regards to the ruby-rnp failures, so I'll add this to the list. Hopefully I can get it finished today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dewyatt !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I see what's up here: https://github.blog/changelog/2020-04-15-github-actions-sets-the-ci-environment-variable-to-true/
Anyways, I'll get this stuff all fixed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure why I wrote it that way originally anyways, it would only install the bundle if CI was not true (which worked because it used to be blank until yesterday). That'll teach me to comment my code I guess. I'll probably just replace that with brew bundle
. Hmm.
7d293aa
to
05477b7
Compare
05477b7
to
a1aba8d
Compare
I modified this to just a simple |
Thanks, @dewyatt! |
Looks like something changed in GHA macos runner, preventing correct installation of json-c. Attempting to fix it.