Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI: Add functions to retrieve information about the recipients. #1174

Merged
merged 6 commits into from
Jun 19, 2020
Merged

FFI: Add functions to retrieve information about the recipients. #1174

merged 6 commits into from
Jun 19, 2020

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jun 17, 2020 •
edited
Loading

This PR adds functions which allows to retrieve:

  • list of keyids/algorithms of public keys message was encrypted to
  • keyid/alg which was used for decryption
  • information about passwords which can be used to decrypt message
  • information about the password which was used for decryption

P.S. I don't 100% like name 'symencs' for password-related informations. Anyone have better suggestion?

Fixes #1107

@ni4
Copy link
Contributor Author

ni4 commented Jun 17, 2020

@kaie Would this interface be suitable for your needs?

rrrooommmaaa
rrrooommmaaa requested changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't have tests for symenc_count > 1 or recipient_count > 1.
Would be nice to add them.

src/lib/rnp.cpp Outdated Show resolved Hide resolved
src/lib/rnp.cpp Outdated Show resolved Hide resolved
ronaldtse
ronaldtse approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4 ni4 force-pushed the ni4-1142-retrieve-recipient-info branch from 1b5b35b to 579c93e Compare June 19, 2020 10:18
@ni4
Copy link
Contributor Author

ni4 commented Jun 19, 2020

Looks like we don't have tests for symenc_count > 1 or recipient_count > 1.
Would be nice to add them.

Please see the updated PR.

@ni4 ni4 force-pushed the ni4-1142-retrieve-recipient-info branch from 579c93e to 09a4ff7 Compare June 19, 2020 10:20
rrrooommmaaa
rrrooommmaaa approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@rrrooommmaaa rrrooommmaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rrrooommmaaa rrrooommmaaa merged commit ac07057 into master Jun 19, 2020
@ni4 ni4 deleted the ni4-1142-retrieve-recipient-info branch August 17, 2020 14:20
@ni4 ni4 added this to the v0.14.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrrooommmaaa rrrooommmaaa rrrooommmaaa approved these changes

@ronaldtse ronaldtse ronaldtse approved these changes

@dewyatt dewyatt Awaiting requested review from dewyatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

Encryption status from rnp_op_verify_*
3 participants
@ni4 @ronaldtse @rrrooommmaaa