Be less strict in userid validity checks. #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ni4
force-pushed
the
ni4-1510-rnp_uid_is_valid-too-strict
branch
from
9fe2cff
to
0963e1a
Compare
|
Is this pending a rebase @ni4 ? |
|
@ronaldtse yeah, waiting for #1523 to pass CI and merge. |
ni4
force-pushed
the
ni4-1510-rnp_uid_is_valid-too-strict
branch
from
0963e1a
to
c9aad67
Compare
ni4
force-pushed
the
ni4-1510-rnp_uid_is_valid-too-strict
branch
from
c9aad67
to
792767c
Compare
ni4
force-pushed
the
ni4-1510-rnp_uid_is_valid-too-strict
branch
from
792767c
to
142a5f4
Compare
…piration time which is in a past.
ni4
force-pushed
the
ni4-1510-rnp_uid_is_valid-too-strict
branch
from
142a5f4
to
4e1552c
Compare
antonsviridenko
approved these changes
Jun 25, 2021
ronaldtse
approved these changes
Jun 27, 2021
|
Thanks @ni4 @antonsviridenko ! |
This was referenced Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes previous behaviour, when userid was considered as invalid if it's self-certification had key expiration time which is in a past.
Fixes #1509