Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor encrypting/decrypting streams for easier adoption of new encryption stream types. #2014

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Mar 16, 2023

It was too hardcoded CFB (Raw/MDC) vs AEAD. These changes should allow easier adoption of new modes.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 78.26% and project coverage change: -0.03 ⚠️

Comparison is base (e4c9bea) 83.36% compared to head (62d5dad) 83.34%.

❗ Current head 62d5dad differs from pull request most recent head 1bee07b. Consider uploading reports for the commit 1bee07b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
- Coverage   83.36%   83.34%   -0.03%     
==========================================
  Files         159      159              
  Lines       31897    31903       +6     
==========================================
- Hits        26590    26588       -2     
- Misses       5307     5315       +8     
Impacted Files Coverage Δ
src/librepgp/stream-parse.cpp 77.25% <67.74%> (-0.44%) ⬇️
src/librepgp/stream-write.cpp 77.55% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ni4 ni4 marked this pull request as ready for review March 20, 2023 14:01
@antonsviridenko antonsviridenko merged commit 4f8add8 into master Mar 20, 2023
@antonsviridenko antonsviridenko deleted the ni4-refactor-aead-flags branch March 20, 2023 17:00
@ni4 ni4 added this to the v0.17.0 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants