Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor encrypted_try_key() for better parameter handling. #2243

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jun 3, 2024

...and no extra pgp_fingerprint() call.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.58%. Comparing base (59a4e92) to head (1fbcf61).

Files Patch % Lines
src/librepgp/stream-parse.cpp 88.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2243   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         107      107           
  Lines       23162    23161    -1     
=======================================
  Hits        19359    19359           
+ Misses       3803     3802    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-update-encrypted-try-key branch from 4f53579 to 09df05b Compare June 24, 2024 09:25
@ni4 ni4 marked this pull request as ready for review June 24, 2024 10:51
@ni4 ni4 force-pushed the ni4-update-encrypted-try-key branch from 09df05b to 1fbcf61 Compare June 25, 2024 08:40
@ni4 ni4 requested review from ronaldtse, maxirmx and desvxx June 25, 2024 10:08
@maxirmx maxirmx merged commit 6224061 into main Jun 26, 2024
128 checks passed
@maxirmx maxirmx deleted the ni4-update-encrypted-try-key branch June 26, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants