Improve accessibility

[BasThomas]

What can still be improved:

• Issue contents (text, images, tables etc.) are not accessible at all (!!!)
• Commit events should be buttons
• Commit events should be selectable
• In an issue, the username is tappable (at the top of a comment cell), but is not specified as a button
• "Assignees" cell is a button, but is not specified as such
• "Reviewers" cell is a button, but is not specified as such
• Expanded labels are also (collapsing) buttons, but are not specified as such
• The tappable username should have an accessibility hint (what does it do? -> open profile in Safari)
• In "All", it is not specified if an issue / PR is unread or not
• Issue / PR status only says its status (eg: "open"), not the fact that it is a status
• Reactions are accessible in reversed order (?): first reactions, then "Add reactions"
• Specify if a comment is self-authored
• Issue statuses should be read as a whole (now accessible per "part", such as username, label, time) -> This means we might want to remove the option to tap a username to open it in SafariVC?
• It is not specified if a cell can be swiped to the left to mark as read, nor is it actionable via VoiceOver (as far as I can tell). This might be fixable within SwipeCellKit?
• Group the Party Popper + No new notifications label
• Hook up "Write comment" to magic tap.
• Make the "more options" button in an issue / PR be called "More options" instead of "bullet" (Add clearer accessibility labels and traits #32)
• Make the "add reaction" button in a comment be called "Add reaction" instead of "plus" (Add clearer accessibility labels and traits #32)
• Add a button trait to both SettingsUserCell and ButtonCell to indicate these are buttons (Add clearer accessibility labels and traits #32)
• Make the user cell in settings make clear this is an account, and tell us when it is selected (or not) (Add clearer accessibility labels and traits #32)
• Make the SettingsVC dismissible with a two-finger Z-swipe in VoiceOver mode. (Add clearer accessibility labels and traits #32)
• Make the "settings" button be called "Settings" instead of "bullets hollow" (Add clearer accessibility labels and traits #32)
• Remove the button trait from buttons used as labels (eg. the "merged" / "open" / "closed" images) (Add clearer accessibility labels and traits #32)
• Makes the More Options button in the issue overview say "More Options" instead of "bullets-hollow" (Improve accessibility of more options button and notification cell #119)
• Makes the notification cell accessible as a whole, as well as mentioning its type (issue, pr or commit) (Improve accessibility of more options button and notification cell #119)
• "Load next page" is not specified as a button (a2e14eb)
• Reactions should have an accessibility hint explaining that tapping them +1s the reaction (or -1 if already reacted) (Add some button accessibility traits #178)
• Reactions are not specified as buttons (Add some button accessibility traits #178)
• "Labels" cell is a button, but is not specified as such (Add some button accessibility traits #178)

Just to keep track of things to do, as it takes quite some time to implement all of it.

[Sherlouk]

@BasThomas Not sure if this issue is intentionally all VoiceOver, or can cover other accessibility things? But also think we should tackle

• Dynamic type (Font Sizes)
• Reduce view controller animations if "reduce motion" is enabled
• Prevent inverting some images (such as profile images) (iOS 11) (Ignore invert colors for profile images + image uploads #750)
• Prevent inverting for profile images in comments

[Sherlouk]

Another thing is the notification cells currently read out each of the subviews (which is definitely an improvement!) but maybe we could make it a bit more conversational and provide a bit more information? An example:

rnystrom Freetime, {Issue/Pull Request} Number 118, Improve Accessibility, Last Updated {an hour ago}

As opposed to:
rnystrom/Freetime #118, an hour ago, Improve Accessibility, Issue

[BasThomas]

Of course accessibility is more than just VoiceOver, so definitely!

On improved labels: we can do that, but that also means it is easier to break (eg. not updating the label when something changes in the future.

[BasThomas]

• Different tab icons for selected / deselected state

[rnystrom]

YES, lets do it. Should be easy.

edit: done!

[BasThomas]

• Badge unread button only tappable on "settings" label #279

[BasThomas]

• https://twitter.com/zats/status/910125012157214721

[BasThomas]

Some more things:

• Code browsing: add types (folder / file) (Improve code browsing accessibility #748)
• Code browsing: files are not buttons (Improve code browsing accessibility #748)
• Markdown actions are all just "buttons"
• Search results are not buttons
• Search: add types (query / repo)

[BasThomas]

Add account button is just “Add”

_{Sent with GitHawk}

[rnystrom]

Linking to #934 for more stuff we can improve

I wonder if we could make a release purely AX focused @BasThomas? Like wrap up a few of these smaller features and then do a bunch of AX?

[BasThomas]

Seems like a great idea if we can get some of the features out of the door first and then focus a bit on AX? :)

[BasThomas]

Maybe even wrap up a bunch of these together with some features for a 2.0?

[rnystrom]

👌👌👌

_{Sent with GitHawk}