Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(rpc): duplicated error from the uber.multierr #129

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: #128

Description of Changes

  • Remove uber.multierr package
  • Use our errors

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s) or (git commit -S).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added this to the 3.1.4 milestone Jun 14, 2021
@rustatian rustatian requested a review from wolfy-j June 14, 2021 09:47
@rustatian rustatian self-assigned this Jun 14, 2021
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #129 (24b2036) into master (b67b3b1) will increase coverage by 0.36%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   56.64%   57.01%   +0.36%     
==========================================
  Files           9        9              
  Lines         542      542              
==========================================
+ Hits          307      309       +2     
+ Misses        202      201       -1     
+ Partials       33       32       -1     
Impacted Files Coverage Δ
pkg/rpc/codec.go 64.00% <45.45%> (+1.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67b3b1...24b2036. Read the comment docs.

@rustatian rustatian merged commit efae571 into master Jun 14, 2021
@bors bors bot deleted the fix/duplicated_error_messages branch June 14, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RPC error message duplication
1 participant