Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: status code in gRPC request metric #77

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Mar 4, 2023

Reason for This PR

roadrunner-server/roadrunner#1194

According to opened issue missing metric is Response codes

Description of Changes

Added response code tag in request_total

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian
Copy link
Member

Thanks @cv65kr 👍🏻

@rustatian rustatian merged commit 02cf4ae into roadrunner-server:master Mar 6, 2023
@rustatian
Copy link
Member

I updated the if-else statement to switch to use the advantage of Go's switch jump tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants