Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2024.1.5 #1947

Merged
merged 2 commits into from
Jun 20, 2024
Merged

release: v2024.1.5 #1947

merged 2 commits into from
Jun 20, 2024

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Jun 20, 2024

Reason for This PR

  • Bugfix release cycle.

Description of Changes

Status plugin:

  • 🐛: Fix k8s-related problem, when status was not available during the graceful shutdown process: BUG. (thanks @cv65kr)

JOBS plugin:

  • 🔥: Experimentally added new handlers for the more canonical ACK, NACK, and REQUEUE operations for the JOBS drivers. PHP SDK will be updated soon. FR, (thanks @shieldz80)

✏️ Future changes:

  • 💡: Configuration includes will be out of experimental status in the next minor release (v2024.2.0) and currently don't have restrictions on where to put the included config. Keep in mind that the path for the included configurations is calculated from the working directory of the RoadRunner process. FR

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Bug Fixes

    • Resolved k8s-related shutdown issue in the Status plugin.
  • New Features

    • Added handlers for ACK, NACK, and REQUEUE operations in the JOBS plugin.
    • Announced future configuration includes becoming non-experimental in v2024.2.0.
  • Chores

    • Updated .gitignore to exclude .DS_Store files.
    • Upgraded multiple dependencies for improved stability and performance.

Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Jun 20, 2024
@rustatian rustatian added this to the v2024.1.5 milestone Jun 20, 2024
@rustatian rustatian requested a review from wolfy-j June 20, 2024 18:52
@rustatian rustatian self-assigned this Jun 20, 2024
Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Walkthrough

The updates involve adding exclusions for .DS_Store files in the .gitignore, implementing bug fixes and new features in the Status and JOBS plugins, and revising the go.mod dependencies for enhanced plugin functionality and future-proofing.


Changes

Files/Paths Change Summary
.gitignore Added exclusion for .DS_Store files and directories recursively
CHANGELOG.md Documented changes for v2024.1.5 release, including bug fixes in Status plugin, and new handlers for JOBS plugin
go.mod Updated various dependencies related to roadrunner-server package

Poem

In the world of code so bright,
Changes sparkle in the night,
From .DS_Store we now flee,
Plugins fixed, jobs run free.
Dependencies up to date,
Roadrunner's sprinting gait.
Code Rabbit cheers with glee, 🌟
For each change brings harmony.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2676eeb and 8cf7610.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (3)
  • .gitignore (1 hunks)
  • CHANGELOG.md (1 hunks)
  • go.mod (6 hunks)
Additional context used
LanguageTool
CHANGELOG.md

[uncategorized] ~26-~26: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ... --- # 🚀 v2024.1.3 🚀 ### RR core: - 🔥: Deprecate RR_* env variables pr...


[formatting] ~27-~27: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause. (COMMA_BEFORE_BECAUSE)
Context: ...ocumented feature which caused confusion, because any configuration value might be automa...


[typographical] ~30-~30: It appears that a comma is missing. (DURING_THAT_TIME_COMMA)
Context: ...drunner-temporal/issues/522). With this change you may replace certificate on a Live s...


[uncategorized] ~30-~30: Possible missing article found. (AI_HYDRA_LEO_MISSING_A)
Context: .../522). With this change you may replace certificate on a Live system. (thanks @benkelukas) ...


[uncategorized] ~44-~44: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...22.4. ## RoadRunner PHP: ### Worker: - 🔥: Add RR_VERSIONenv to theEnvi...


[uncategorized] ~74-~74: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...drunner-server/grpc/pull/133) ### SDK: - 🔥 Additional debug logging for the `...


[uncategorized] ~89-~89: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...iguration) (thanks @dkomarek) ### SDK: - 🔥 Use a small random jitter to preve...

Markdownlint
CHANGELOG.md

5-5: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


18-18: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


26-26: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


52-52: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


68-68: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


21-21: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines


47-47: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines


5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


26-26: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


29-29: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


33-33: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


36-36: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


39-39: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


44-44: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


52-52: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


55-55: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


58-58: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


61-61: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


68-68: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


71-71: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


74-74: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


86-86: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


89-89: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


3-3: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


16-16: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


24-24: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


50-50: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


66-66: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


79-79: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


5-5: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


8-8: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


11-11: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


18-18: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


26-26: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


29-29: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


36-36: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


39-39: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


42-42: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


44-44: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


52-52: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


55-55: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


58-58: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


61-61: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


68-68: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


71-71: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


74-74: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


83-83: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


86-86: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


89-89: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


12-12: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


19-19: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


27-27: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


30-30: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


34-34: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


37-37: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


40-40: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


45-45: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


53-53: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


56-56: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


59-59: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


62-62: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


69-69: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


72-72: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


75-75: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


84-84: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


87-87: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


90-90: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines

Additional comments not posted (3)
.gitignore (1)

25-26: The addition of .DS_Store to the .gitignore is correctly implemented to ensure these files are ignored across all directories.

CHANGELOG.md (1)

3-13: The CHANGELOG entries for the Status and JOBS plugins, as well as the note on future changes, are clear and well-documented with appropriate links to the issues.

Tools
Markdownlint

5-5: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time


5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines


3-3: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document


5-5: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


8-8: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


11-11: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading


6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines


12-12: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines

go.mod (1)

11-49: The updates to the dependencies in the go.mod file are correctly versioned and follow semantic versioning principles.

@rustatian rustatian merged commit 2b72beb into master Jun 20, 2024
12 checks passed
@rustatian rustatian deleted the release/v2024.1.5 branch June 20, 2024 19:03
@coderabbitai coderabbitai bot mentioned this pull request Sep 12, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant