-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: v2024.1.5
#1947
release: v2024.1.5
#1947
Conversation
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
Signed-off-by: Valery Piashchynski <piashchynski.valery@gmail.com>
WalkthroughThe updates involve adding exclusions for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (3)
- .gitignore (1 hunks)
- CHANGELOG.md (1 hunks)
- go.mod (6 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[uncategorized] ~26-~26: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ... --- # 🚀 v2024.1.3 🚀 ###RR core
: - 🔥: DeprecateRR_*
env variables pr...
[formatting] ~27-~27: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause. (COMMA_BEFORE_BECAUSE)
Context: ...ocumented feature which caused confusion, because any configuration value might be automa...
[typographical] ~30-~30: It appears that a comma is missing. (DURING_THAT_TIME_COMMA)
Context: ...drunner-temporal/issues/522). With this change you may replace certificate on a Live s...
[uncategorized] ~30-~30: Possible missing article found. (AI_HYDRA_LEO_MISSING_A)
Context: .../522). With this change you may replace certificate on a Live system. (thanks @benkelukas) ...
[uncategorized] ~44-~44: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...22.4. ## RoadRunner PHP: ###
Worker: - 🔥: Add
RR_VERSIONenv to the
Envi...
[uncategorized] ~74-~74: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...drunner-server/grpc/pull/133) ###SDK
: - 🔥 Additional debug logging for the `...
[uncategorized] ~89-~89: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...iguration) (thanks @dkomarek) ###SDK
: - 🔥 Use a small random jitter to preve...
Markdownlint
CHANGELOG.md
5-5: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
18-18: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
26-26: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
52-52: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
68-68: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
21-21: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
47-47: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
18-18: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
26-26: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
29-29: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
33-33: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
36-36: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
39-39: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
44-44: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
52-52: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
55-55: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
58-58: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
61-61: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
68-68: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
71-71: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
74-74: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
83-83: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
86-86: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
89-89: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
3-3: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
16-16: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
24-24: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
50-50: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
66-66: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
79-79: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
5-5: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
8-8: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
11-11: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
18-18: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
26-26: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
29-29: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
36-36: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
39-39: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
42-42: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
44-44: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
52-52: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
55-55: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
58-58: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
61-61: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
68-68: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
71-71: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
74-74: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
83-83: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
86-86: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
89-89: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
12-12: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
19-19: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
27-27: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
30-30: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
34-34: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
37-37: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
40-40: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
45-45: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
53-53: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
56-56: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
59-59: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
62-62: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
69-69: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
72-72: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
75-75: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
84-84: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
87-87: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
90-90: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
Additional comments not posted (3)
.gitignore (1)
25-26
: The addition of.DS_Store
to the.gitignore
is correctly implemented to ensure these files are ignored across all directories.CHANGELOG.md (1)
3-13
: The CHANGELOG entries for theStatus
andJOBS
plugins, as well as the note on future changes, are clear and well-documented with appropriate links to the issues.Tools
Markdownlint
5-5: Expected: h2; Actual: h3 (MD001, heading-increment)
Heading levels should only increment by one level at a time
5-5: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
11-11: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
3-3: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
5-5: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
8-8: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
11-11: Punctuation: ':' (MD026, no-trailing-punctuation)
Trailing punctuation in heading
6-6: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
9-9: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
12-12: null (MD032, blanks-around-lists)
Lists should be surrounded by blank linesgo.mod (1)
11-49
: The updates to the dependencies in thego.mod
file are correctly versioned and follow semantic versioning principles.
Reason for This PR
Description of Changes
Status
plugin:JOBS
plugin:ACK
,NACK
, andREQUEUE
operations for theJOBS
drivers. PHP SDK will be updated soon. FR, (thanks @shieldz80)✏️ Future changes:
v2024.2.0
) and currently don't have restrictions on where to put the included config. Keep in mind that the path for the included configurations is calculated from the working directory of the RoadRunner process. FRLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
Bug Fixes
New Features
Chores