Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed propTypes to use npm package prop-types #4

Merged
merged 1 commit into from
Jul 3, 2017
Merged

changed propTypes to use npm package prop-types #4

merged 1 commit into from
Jul 3, 2017

Conversation

NicholasLYang
Copy link
Contributor

Just updated propTypes to use the separate npm package prop-types. propTypes in react will be deprecated with v16.0.0

@rob2d
Copy link
Owner

rob2d commented Jul 3, 2017

Thanks for taking care of that Nick. Since the prop-types aren't actually used, we can actually also remove the import (which would cut down a bit of overhead for the base template). Will make note of that. Still debating whether to include prop-types or not because there is a minority of React devs that opt either not to use them now that stateless components describe props better, or to go with typescript.

@rob2d rob2d merged commit 3b929fe into rob2d:master Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants