Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorSync is deprecated #1

Closed
robaho opened this issue Oct 25, 2017 · 2 comments
Closed

ColorSync is deprecated #1

robaho opened this issue Oct 25, 2017 · 2 comments
Assignees
@robaho

Comments

@robaho
Copy link
Owner

robaho commented Oct 25, 2017

Apple has deprecated ColorSync and Seashore uses this when working with CMYK and other operations - like embedding color profiles in the image.

The functionality has been disabled to avoid runtime errors, and everything seems to be working OK for standard file types and color spaces.
@robaho
Copy link
Owner Author

robaho commented Oct 31, 2018

Btw, the ColorSync was re-enabled a while back, but still need to figure out an update path - probably need to use CoreGraphics which is a pretty big change - not sure when the time will be available.

robaho added a commit that referenced this issue Dec 21, 2018
@robaho
partial fix on issue #1, remove ColorSync from image reading, writing…
4b43d70 
… still to do...
@robaho robaho mentioned this issue Dec 21, 2018
Closed
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
partial fix issue #1, remove more ColorSync, render CMYK using NSBitm…
c77f28e 
…apImageRep
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
fix issue #1, remove launch of ColorSync
49af8c6
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
issue #1, simplify saving of tiff
009c47b
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
issue #1, strip redundant alpha channel
be31c60
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
issue #1, remove more ColorSync code
5344e5e
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
issue #1, need to retain Size for proper dpi changes
8f4848e
robaho added a commit that referenced this issue Dec 22, 2018
@robaho
issue #1, properly release memory used for temporary images
2fe058d
robaho added a commit that referenced this issue Dec 23, 2018
@robaho
issue #1, save images using calibrated color spaces
913fc5e
@robaho
Copy link
Owner Author

robaho commented Dec 23, 2018

fixed, still need to investigate including color profiles in the saved images

@robaho robaho closed this as completed Dec 23, 2018
@robaho robaho self-assigned this Dec 23, 2018
@robaho robaho mentioned this issue Jun 20, 2019
Closed
@robaho robaho mentioned this issue Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robaho robaho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robaho