Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #46

Merged
merged 17 commits into from
Jan 8, 2017
Merged

Refactoring #46

merged 17 commits into from
Jan 8, 2017

Conversation

zoetrope69
Copy link
Collaborator

@zoetrope69 zoetrope69 commented Dec 13, 2016 •
edited
Loading

This PR:

  1. Simplifies how data is used in the application
  2. Restructures components so they're not nested
  3. Adds hot reloading
  4. Removes need for babel for the server/webpack
  5. Adds a new style to the logo

TODO:

  • Move any data manipulation as high as possible
  • Fix production method and instructions

Zac Colley added 3 commits December 27, 2016 16:57
Merge branch 'master' into refactor
084666e 
* master:
  Starting work on making the category icons a component (#45)
Reimplement local amount icon
c441785
Flattened component structure
3e84018
@robcalcroft
Copy link
Owner

@zaccolley should I wait till this is finished before doing a release?

@zoetrope69
Copy link
Collaborator Author

I'll get this done this week

Zac Colley added 12 commits January 5, 2017 02:02
@zoetrope69 zoetrope69 changed the title [WIP] Refactoring [Refactoring Jan 7, 2017
@zoetrope69 zoetrope69 changed the title [Refactoring Refactoring Jan 7, 2017
@zoetrope69 zoetrope69 mentioned this pull request Jan 7, 2017
Merged
@robcalcroft robcalcroft merged commit dbe166e into master Jan 8, 2017
@robcalcroft robcalcroft mentioned this pull request Jan 8, 2017
Closed
@zoetrope69 zoetrope69 mentioned this pull request Jan 8, 2017
Closed
5 tasks
@robcalcroft robcalcroft deleted the refactor branch December 11, 2017 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoetrope69 @robcalcroft