Arguments fix

[thyseus]

Assume we have a command:

        protected $signature = 'group:backup {server}';

and configure laravel-database-schedule to run, currently it runs:

php artisan group:backup server='my-server'

which is wrong; it should run:

php artisan group:backup my-server

This MR fixes that problem.

[thyseus]

@robersonfaria i am struggling with fixing this test:

https://github.com/robersonfaria/laravel-database-schedule/runs/5251370512

do you have an idea what is going on ?

[robersonfaria]

It's exactly the point where you changed, before you received server='my-server', now you only receive the value, in the test you have to test the same.

In the tests/Unit/ScheduleCommandsTest.php file on the line 67 you need to change to:
->with('inspire', ['1'])

so it should work

[thyseus]

@robersonfaria thanks a lot, that was easy. Do you agree in general that this is the better expected behavior of laravel-database-schedule ?

[robersonfaria]

I do believe it makes sense, my only concern is how to release this version, whether as a minor or major version.

I haven't been able to analyze yet if this modification can impact any application in production.

It doesn't seem to have an impact, but I haven't really stopped to analyze it, do you see any possible impact?

[thyseus]

You are right, its a kind of breaking change. We should either create a 'Changelog' chapter in the README.md or a CHANGELOG.md file describing what we changed. A 1.3 instead of 2.0 is appropriate in my opinion.