Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing/running the spell checker #25

Closed
bedohave opened this issue Sep 24, 2018 · 7 comments
Closed

Installing/running the spell checker #25

bedohave opened this issue Sep 24, 2018 · 7 comments
Labels
bug Something isn't working user-feedback Waiting for feedback from user

Comments

@bedohave
Copy link

Howdy!

Thanks for all your work. 2.1 is running very well for me,

Can you tell me how to install the spell checker? (Or point me to where I can RTFM?)

I get the same message and I tried following instructions here: baumgarr#292

But the latest nixnote-hunspell-plugin I was able to find (2.0.2) has a hard dependency on an older version of hunspell (libhunspell-1.3-0). I am running Ubuntu 18.04 with libhunspell-1.6.0 is installed.

Thanks!

@robert7
Copy link
Owner

robert7 commented Sep 25, 2018

I think this doesn't work yet in v2.1. I did not tried spellcheck so far, but I think there are some hardcoded paths and it will need minor adjustments.
I will need to check.

@robert7 robert7 added the bug Something isn't working label Sep 25, 2018
@bedohave
Copy link
Author

bedohave commented Sep 26, 2018 via email

@robert7
Copy link
Owner

robert7 commented Oct 3, 2018

@bedohave
The spellchecking should now work (from version 2.1.0-beta4g). You can try it now using "development" version of AppImage.
I needed to rewrite quite lot of the code, I don't believe this could previously work on anything else then the original developer machine :) ..the spellchecker is now embedded, as the plugin version was just kind of useless difficulty.

There still may be issues, as the actual implementation is quite simple, but it should be usable. Pls test it and let me know about any issues (in case you are using the PPA version, its ok for you to download the AppImage - just quit the Ubuntu PPA version, download AppImage build, mark as executable and run .. after you finish testing, you can return to the PPA version).

@bedohave
Copy link
Author

bedohave commented Oct 3, 2018

Hi @robert7

That works. When I first ran the embedded spellcheck in 2.1.0-beta4g, I got a 'hunspell missing or no dictionary' error. Turns out I had an empty Language (Edit/Preferences/Locale). Set to English US and the spell checker worked as before.

semi-n00b Q: How will I know when the PPA version has this fix in it?

Thank you!

@artmg
Copy link

artmg commented Oct 3, 2018

@robert7 pls let me know if I can help with changes to get PPA working +Art

@robert7
Copy link
Owner

robert7 commented Oct 9, 2018

@bedohave

How will I know when the PPA version has this fix in it?

I described the "current pipeline.."... but basically it happens short after the "develop" branch is merged to "master".

The merge develop to master can take some time - see the linked wiki article - its no problem to combine the PPA version with the AppImage - so either you can wait until the merge happens or temporarily you may switch to the AppImage build.

When I first ran the embedded spellcheck in 2.1.0-beta4g, I got a 'hunspell missing or no dictionary' error. Turns out I had an empty Language (Edit/Preferences/Locale)

This is a bug - there is afallback... but I see, it did not worked as I intended - so I'll fix it.

@artmg thanks. So far the PPA works fine. I already activated the automatic build after commit in the "master" branch... so today I merged "develop" to master, let see tomorrow if there is new pkg in the PPA :)

@robert7
Copy link
Owner

robert7 commented Oct 12, 2018

When I first ran the embedded spellcheck in 2.1.0-beta4g, I got a 'hunspell missing or no dictionary' error. Turns out I had an empty Language (Edit/Preferences/Locale). Set to English US and the spell checker worked as before.

The missing fallback problem is now fixed. it would be nice, if you can retest, if it now works regardless on how you have Preferences set. To simulate missing language you could delete it manually in the "conf" file see screenshoot. (Make a backup before)

"nixnote-2.conf" is for the 2nd account
screen_20181012_06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user-feedback Waiting for feedback from user
Projects
None yet
Development

No branches or pull requests

3 participants