Actually check E2E test output, add more context to output errors #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
force-pushed
the
check-test-e2e-output
branch
from
949d624
to
45e817e
Compare
robertknight
changed the title
- Replace the `FileErrorContext` trait with the anyhow crate, which provides better support for adding context to errors. - Use `anyhow::with_context` to add contexts to errors reported when creating output file fails.
Unlike `/tmp`, this works on GitHub Actions on Windows. See https://docs.github.com/en/actions/learn-github-actions/contexts#runner-context
robertknight
force-pushed
the
check-test-e2e-output
branch
from
45e817e
to
5c100e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
make test-e2eactually check the text produced against expectations.In the process of debugging a CI failure, the error messages produced when writing the output file fails have also been improved.